Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Split Balanced Payments section to make way for Coinbase #2297

Closed
3 of 4 tasks
ESWAT opened this issue Apr 18, 2014 · 6 comments · Fixed by #2307
Closed
3 of 4 tasks

Split Balanced Payments section to make way for Coinbase #2297

ESWAT opened this issue Apr 18, 2014 · 6 comments · Fixed by #2307
Assignees

Comments

@ESWAT
Copy link

ESWAT commented Apr 18, 2014

Need to continue chipping-away at #2053 by redesigning the Balanced Payments section of Connected Accounts, to match this mock and make way for Coinbase intergration.

This Issue will also tackle showing the Coinbase section - to make sure it fits nicely - but it will likely be hidden before merge.

screen shot 2014-02-19 at 11 53 12 pm

Tasklist

  • Copy assets needed from coinbase branch
  • Split Balanced Payments section
  • Hookup new markup
  • Design Coinbase section
@ESWAT
Copy link
Author

ESWAT commented Apr 19, 2014

In the coinbase branch, when you add a Credit Card or a Bank account, instead of None we show the card carrier and the last four digits, and for the bank account the “name’ of the bank account.

Do we still want to continue with this labelling or use something more generic like we have with the ✔ and ✘?

@seanlinsley
Copy link
Contributor

In the coinbase branch, when you add a Credit Card or a Bank account, instead of None we show the card carrier and the last four digits, and for the bank account the “name’ of the bank account.

I think that information is fine to show if it's your own account and you're logged in, but we certainly shouldn't show that info publicly. Maybe we should just hide the section for everyone else. (ref: #653)

@clone1018
Copy link
Contributor

I see value in keeping at least the connected bank status public. I'd rather not tip someone who just let's the money sit in Gittip's escrow.

@seanlinsley
Copy link
Contributor

I see value in keeping at least the connected bank status public. I'd rather not tip someone who just let's the money sit in Gittip's escrow.

@clone1018
Copy link
Contributor

I do get to choose how my money gets spent on others though. I'd like Bitcoin and Paypal withdraw to be more visible too.

@ESWAT
Copy link
Author

ESWAT commented Apr 21, 2014

Reading the comments and #653 I’m going to opt for not showing anything publicly and just showing whether you have an account added or not when you’re seeing your own profile.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants