Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Team take not included in total received. #1139

Closed
johana-star opened this issue Jul 13, 2013 · 12 comments · Fixed by #2496
Closed

Team take not included in total received. #1139

johana-star opened this issue Jul 13, 2013 · 12 comments · Fixed by #2496

Comments

@johana-star
Copy link
Contributor

On profile pages members of gittip have a total like:
Strand receives: $3.25 per week.

However this number underreports the amount someone receives when some of their contributions come from teams. The screenshot below shows my team contribution as an anonymous transaction at the bottom of the list.

screen shot 2013-07-13 at 8 22 12 am

I expect the total a member receives listed on their profile page to include funds from teams.

@cakey
Copy link
Contributor

cakey commented Jul 13, 2013

+1

@chadwhitacre
Copy link
Contributor

@ceboudreaux Didn't you ticket this already?

@ceboudreaux
Copy link
Contributor

Yes, closing in favor of #1126 and #1127

@chadwhitacre
Copy link
Contributor

Reopening. #1126 is about the entry in the history page; #1127 is about whether givers have a credit card attached. Including team takes in receiving deserves it's own ticket.

@chadwhitacre
Copy link
Contributor

+1 from @helmo on #2049:

As a team member on gittip you start out getting $0.01 per week.

However after two weeks the top right corner of my gittip pages still is say "Receiving: $0.00/wk".
While on the team's history tab I can see that a cent has been debited from the balance. And on my personal history page I can see the cent being credited.

Rounding error?

[edit] just the "Receiving: $0.00/wk" is bad ... balance seems OK.

@duckinator
Copy link
Contributor

+1

@rummik
Copy link
Contributor

rummik commented Mar 22, 2014

Would be really handy to have this :P +1 from me as well

I'd do it, but I'm way too nervous about touching anything that changes the DB right now

Edit: I'm actually -0 on this. I think there should be a total receiving, but I think the number on profiles should be the amount being gifted to a user

@sim6
Copy link
Contributor

sim6 commented Mar 29, 2014

As @seanlinsley says at #2203, we need a distinction between money given directly by others, and money requested as a member of a team. How can we can do that?

@ESWAT
Copy link

ESWAT commented Mar 29, 2014

+1.

As for distinction between team take and direct gifts, I don’t believe we need to make this distinction in the header after #2203 is on prod, but it would be nice to have it in the History page.

Splitting the transaction to 'from others' - I’m not a fan of the 'from someone' wording personally - and 'from team' would be the simplest solution.

@rummik
Copy link
Contributor

rummik commented Mar 29, 2014

Seems like we could help explain this by some wording changes. So, like, instead of 'Person receives $X on Gittip', we could say, 'Person is gifted $X on Gittip', so there's better separation between gifts from users and team takes.

@rummik
Copy link
Contributor

rummik commented Mar 29, 2014

(I'm actually changing to -0 on this)

@sim6
Copy link
Contributor

sim6 commented Mar 31, 2014

@ESWAT please, take a look at #1126 and #2173

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
8 participants