Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2021-01-07] Schema Coordinates: Add functions to graphql-js for schema coordinate parsing/printing #581

Closed
magicmark opened this issue Jan 8, 2021 · 1 comment
Assignees
Labels
Action item 🎬 Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings.

Comments

@magicmark
Copy link
Contributor

Add functions to graphql-js for schema coordinate parsing/printing


Lee: regarding reference implementation changes, we should add at least parsing functions to allow parsing into an AST and printing an AST back out again. That would give people the tools they need to use this; and I think that's needed for RFC2.
Lee: another (not required to move it to RFC2) would be to have a function that you pass a schema reference to and get a schema coordinate out.
Lee: another: given a schema and a schema coordinate, return out the thing that that schema coordinate refers to. Also not required for RFC2.
Lee: the parse/print will help us write tests and ensure we've dotted the i's and crossed the t's.
ACTION - Mark - implement the print/parse functions.

@benjie benjie changed the title [2020-01-07] Schema Coordinates: Add functions to graphql-js for schema coordinate parsing/printing [2021-01-07] Schema Coordinates: Add functions to graphql-js for schema coordinate parsing/printing Jan 8, 2021
@leebyron leebyron added the Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings. label Jun 2, 2021
@leebyron
Copy link
Collaborator

leebyron commented Jun 2, 2021

Added in graphql/graphql-js#3044

@leebyron leebyron closed this as completed Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Action item 🎬 Ready for review 🙌 Action Item issues are reviewed and closed during Working Group meetings.
Projects
None yet
Development

No branches or pull requests

2 participants