Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graphql-js.org is only partially deprecated #4200

Closed
yaacovCR opened this issue Sep 23, 2024 · 1 comment · Fixed by #4240
Closed

graphql-js.org is only partially deprecated #4200

yaacovCR opened this issue Sep 23, 2024 · 1 comment · Fixed by #4240

Comments

@yaacovCR
Copy link
Contributor

It looks like graphql-js.org has been deprecated in favor of graphql.org/graphql-js. Our README even points to graphql.org/graphql-js.

So we really should:

  1. add the latest additional content from graphql-js.org to graphql.org/graphql-js (see add additional content from graphql-js repository graphql.github.io#1782)
  2. redirect from graphql-js.org to graphql.org/graphql-js or point graphql-js.org to graphql.org/graphql-js
  3. remove the old website from the graphql-js repo.

I am not in a position to do 2, but have submitted a PR doing 1, and once 2 is done, I can do 3.
@yaacovCR
Copy link
Contributor Author

@saihaj @dimaMachina

This was referenced Oct 15, 2024
Closed
Merged
JoviDeCroock added a commit that referenced this issue Oct 20, 2024
@JoviDeCroock @yaacovCR
Convert from docusaurus to nextra (#4240)
d1c9c42 
This converts the existing docusaurus website to nextra just like
https://github.com/graphql/graphql.github.io. This is a first step in
moving the documentation here and having a redirect from graphql.org to
graphql-js.org.

Not sure yet why codecov started failing 😅 when I run `testonly:cover`
locally it tells me we are 100% covered.

WDYT about isolating the dependencies for the website in that folder? As
seen in
9c7d615
this prevents the weird CI leaks that we're seeing

Resolves #4200

---------

Co-authored-by: Yaacov Rydzinski <[email protected]>
yaacovCR added a commit to yaacovCR/graphql-js that referenced this issue Nov 26, 2024
@JoviDeCroock @yaacovCR
Convert from docusaurus to nextra (graphql#4240)
1048ce9 
This converts the existing docusaurus website to nextra just like
https://github.com/graphql/graphql.github.io. This is a first step in
moving the documentation here and having a redirect from graphql.org to
graphql-js.org.

Not sure yet why codecov started failing 😅 when I run `testonly:cover`
locally it tells me we are 100% covered.

WDYT about isolating the dependencies for the website in that folder? As
seen in
graphql@9c7d615
this prevents the weird CI leaks that we're seeing

Resolves graphql#4200

---------

Co-authored-by: Yaacov Rydzinski <[email protected]>
yaacovCR added a commit to yaacovCR/graphql-js that referenced this issue Dec 3, 2024
@JoviDeCroock @yaacovCR
Convert website to nextra (graphql#4240)
566a82a 
This converts the existing website to nextra just like
https://github.com/graphql/graphql.github.io. This is a first step in
moving the documentation here and having a redirect from graphql.org to
graphql-js.org.

Not sure yet why codecov started failing 😅 when I run `testonly:cover`
locally it tells me we are 100% covered.

WDYT about isolating the dependencies for the website in that folder? As
seen in
graphql@9c7d615
this prevents the weird CI leaks that we're seeing

Resolves graphql#4200

---------

Co-authored-by: Yaacov Rydzinski <[email protected]>
yaacovCR added a commit to yaacovCR/graphql-js that referenced this issue Dec 3, 2024
@JoviDeCroock @yaacovCR
Convert website to nextra (graphql#4240)
71f8c31 
This converts the existing website to nextra just like
https://github.com/graphql/graphql.github.io. This is a first step in
moving the documentation here and having a redirect from graphql.org to
graphql-js.org.

Not sure yet why codecov started failing 😅 when I run `testonly:cover`
locally it tells me we are 100% covered.

WDYT about isolating the dependencies for the website in that folder? As
seen in
graphql@9c7d615
this prevents the weird CI leaks that we're seeing

Resolves graphql#4200

---------

Co-authored-by: Yaacov Rydzinski <[email protected]>
yaacovCR added a commit to yaacovCR/graphql-js that referenced this issue Dec 3, 2024
@JoviDeCroock @yaacovCR
Convert website to nextra (graphql#4240)
9cf14db 
This converts the existing website to nextra just like
https://github.com/graphql/graphql.github.io. This is a first step in
moving the documentation here and having a redirect from graphql.org to
graphql-js.org.

Not sure yet why codecov started failing 😅 when I run `testonly:cover`
locally it tells me we are 100% covered.

WDYT about isolating the dependencies for the website in that folder? As
seen in
graphql@9c7d615
this prevents the weird CI leaks that we're seeing

Resolves graphql#4200

---------

Co-authored-by: Yaacov Rydzinski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Convert from docusaurus to nextra graphql/graphql-js
1 participant
@yaacovCR