From 16c69d30985501e47f1c40ad727bbe034a8db40f Mon Sep 17 00:00:00 2001 From: Rikki Schulte Date: Sun, 15 Sep 2024 21:13:54 +0200 Subject: [PATCH 1/5] fix eslint issue --- packages/graphiql/cypress/e2e/incremental-delivery.cy.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/graphiql/cypress/e2e/incremental-delivery.cy.ts b/packages/graphiql/cypress/e2e/incremental-delivery.cy.ts index d4f65d9b4c..d10273434b 100644 --- a/packages/graphiql/cypress/e2e/incremental-delivery.cy.ts +++ b/packages/graphiql/cypress/e2e/incremental-delivery.cy.ts @@ -1,4 +1,4 @@ -import { version } from 'graphql'; +// import { version } from 'graphql'; let describeOrSkip: Mocha.SuiteFunction | Mocha.PendingSuiteFunction = describe; // TODO: add support to graphql-http for IncrementalDelivery first From 34467728cc2838596bf2b82cf76da34db229f60c Mon Sep 17 00:00:00 2001 From: Rikki Schulte Date: Sun, 15 Sep 2024 21:15:59 +0200 Subject: [PATCH 2/5] temporarily disable main branch filter --- .github/workflows/pr-graphql-compat-check.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-graphql-compat-check.yml b/.github/workflows/pr-graphql-compat-check.yml index da0c1c2098..6ed9f0ef6b 100644 --- a/.github/workflows/pr-graphql-compat-check.yml +++ b/.github/workflows/pr-graphql-compat-check.yml @@ -4,8 +4,8 @@ on: # only on merge to main. # it's rare that this workflow would # show us an error, but when it does it's important! - branches: - - main + # branches: + # - main # don't run this regression suite if we don't need to paths-ignore: - '**.md' From 464b47746844982757e6cca326fc327f60e2ba6b Mon Sep 17 00:00:00 2001 From: Rikki Schulte Date: Sun, 15 Sep 2024 21:18:00 +0200 Subject: [PATCH 3/5] temporarily enable latest stable 15 --- .github/workflows/pr-graphql-compat-check.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/pr-graphql-compat-check.yml b/.github/workflows/pr-graphql-compat-check.yml index 6ed9f0ef6b..448398b03a 100644 --- a/.github/workflows/pr-graphql-compat-check.yml +++ b/.github/workflows/pr-graphql-compat-check.yml @@ -24,6 +24,8 @@ jobs: strategy: matrix: release: + # try last stable 15 release again + - '^15' # test against the latest 16.x version, which might be newer than what we have - '^16' # test against the oldest version we support From e91fdbbe56e3d48cf249f4373fb44c63369dc2e4 Mon Sep 17 00:00:00 2001 From: Rikki Schulte Date: Mon, 16 Sep 2024 11:23:35 +0200 Subject: [PATCH 4/5] remove 15 from test matrix --- .github/workflows/pr-graphql-compat-check.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/pr-graphql-compat-check.yml b/.github/workflows/pr-graphql-compat-check.yml index 448398b03a..6ed9f0ef6b 100644 --- a/.github/workflows/pr-graphql-compat-check.yml +++ b/.github/workflows/pr-graphql-compat-check.yml @@ -24,8 +24,6 @@ jobs: strategy: matrix: release: - # try last stable 15 release again - - '^15' # test against the latest 16.x version, which might be newer than what we have - '^16' # test against the oldest version we support From e5b6ff1beb0004065363a3b569d85947e9eb7791 Mon Sep 17 00:00:00 2001 From: Rikki Schulte Date: Mon, 16 Sep 2024 11:52:28 +0200 Subject: [PATCH 5/5] re-enable branch filter --- .github/workflows/pr-graphql-compat-check.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-graphql-compat-check.yml b/.github/workflows/pr-graphql-compat-check.yml index 6ed9f0ef6b..da0c1c2098 100644 --- a/.github/workflows/pr-graphql-compat-check.yml +++ b/.github/workflows/pr-graphql-compat-check.yml @@ -4,8 +4,8 @@ on: # only on merge to main. # it's rare that this workflow would # show us an error, but when it does it's important! - # branches: - # - main + branches: + - main # don't run this regression suite if we don't need to paths-ignore: - '**.md'