Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v4] generate types with vite-plugin-dts #3702

Merged
merged 8 commits into from
Aug 9, 2024

Conversation

dimaMachina
Copy link
Collaborator

No description provided.

Copy link

changeset-bot bot commented Aug 8, 2024

🦋 Changeset detected

Latest commit: 95bf55f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@graphiql/react Minor
@graphiql/plugin-explorer Major
@graphiql/plugin-code-exporter Major
graphiql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dimaMachina dimaMachina changed the title generate types with vite-plugin-dts [v4] generate types with vite-plugin-dts Aug 8, 2024
Copy link
Contributor

github-actions bot commented Aug 8, 2024

The latest changes of this PR are not available as canary, since there are no linked changesets for this PR.

@acao
Copy link
Member

acao commented Aug 9, 2024

if you're interested, there is a previous PR where i introduced a shared vite config plugin to use for graphiql plugins, I can look it up if you like

@dimaMachina
Copy link
Collaborator Author

Do you talk about #3346? I will take a look

I don't think it's a good approach to publish shared vite config as an npm module, but we could use it internally in monorepo to DRY in plugins / graphiql-react and graphiql

@dimaMachina dimaMachina merged commit 00415d2 into graphiql-v4 Aug 9, 2024
14 checks passed
@dimaMachina dimaMachina deleted the use-vite-dts-in-graphiql-react branch August 9, 2024 11:50
@acao acao mentioned this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants