Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lsp server paths for windows, special chars, fragment/object cache #2072

Merged
merged 3 commits into from
Nov 30, 2021
Merged

fix: lsp server paths for windows, special chars, fragment/object cache #2072

merged 3 commits into from
Nov 30, 2021

Commits on Nov 30, 2021

  1. fix: lsp server paths for windows, special chars 

    using the standard `vscode-uri` package, this should fix the parsing of file URIs by `graphql-language-service-server` in cases such as:

- windows without WSL
- special/unicode characters in filenames
- likely other cases

previously we were using the old approach of `URL(uri).pathname` which was not working!

this should fix issues with object and fragment type completion as well I think
    @acao
    acao committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    04a2552 View commit details
    Browse the repository at this point in the history

  2. fix file URI parsing for windows

    @acao
    acao committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    bf16500 View commit details
    Browse the repository at this point in the history

  3. remove filePathToUrl as well, fix tests

    @acao
    acao committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    4a3bf20 View commit details
    Browse the repository at this point in the history