Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lsp-server] 🐞 Goto definition of a Scalar defined in separate SDL file does not work #2989

Closed
1 task done
jogly opened this issue Jan 9, 2023 · 0 comments · Fixed by #3163
Closed
1 task done
Labels
bug lsp-server graphql-language-service-server

Comments

@jogly
Copy link

jogly commented Jan 9, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Goto-definition does not work ("definition not found") for scalars defined in other schema files. It does work for scalars defined in the same file.

Expected Behavior

I expect Goto-definition of a scalar type to navigate to the location of definition for that scalar, regardless of which file it is declared in.

Steps To Reproduce

Repro repo: https://github.com/jogly/graphql-goto-definition

  1. Open the repo in VSCode with the GraphQL LSP extension installed with no custom settings.
  2. In the file query.gql, goto does not work on the scalar reference AScalar, but does work on ATypeDef.
  3. In the file typedef.gql, goto does work on the scalar reference World

Environment

  • LSP Server Version: v2.9.4
  • OS: Mac OS
  • LSP Client: vscode v1.74.2 & graphql.vscode-graphql v0.8.4

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug lsp-server graphql-language-service-server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant