Introspection Query always uses initial headers

[3nvi]

In the latest v1.9.x. release, the headers used for the introspection query (and potentially for other queries as well) are never updated, but instead, retain their initial value.

The culprit here is this effect. Whenever I change the headers in the secondary editor (regardless of whether their value is controlled or not), the useEffect never fires, cause the headerEditor is always null no matter what I've tried here.

Thus the headers.current ref always holds its initial value.

After some searching, I traced it down to the fact that you're attempting to read the EditorContext from within SchemaContextProvider. Funnily though, the SchemaContextProvider wraps the EditorContext and that's why you're not getting any updates there. Reversing the order of the providers should fix it unless the order of the providers was like that for a particular reason (haven't delved deeper into the latter).

I'm willing to work on a PR if you feel that a component order reverse shouldn't create any major problems.

Thanks!

P.S. For anyone else encountering this, at the moment of writing, the last working version is v1.8.10

[acao]

Thank you for reporting this @3nvi !

[thomasheyenbrock]

Hey @3nvi and thanks again for reporting!

Currently the EditorContext currently uses the SchemaContext (see here) for providing some methods on the context object, so just switching would break the EditorContext.

Eventually I wanted to move these methods (autoCompleteLeafs, copy, merge, and prettify) out of the context and into reusable hooks. I didn't do it yet because the main GraphiQLWithContext component is still a class component and can't consume hooks. However we could do this and call the hooks in a new function component that wraps GraphiQLWithContext. This new component would call the hooks and pass the methods down as prop. After we did that, we could switch the context providers. Lmk if that explanation made sense to you 🙂

Happy if you wanna work on this, otherwise I'd address this start of next week!

[3nvi]

Given that you already have a plan laid out, I feel that it would take a lot of back-and-forth between us to align in the approach. I'll let you work on it, but feel free to ping me if you need help or turns out that you don't have any free time :)

[thomasheyenbrock]

That sounds good to me! I'll take a look into this later today.