Skip to content
This repository has been archived by the owner on Mar 20, 2023. It is now read-only.

update peer dep version reference of graphql from 0.11 to 0.12.3 #407

Closed
wants to merge 1 commit into from
Closed

update peer dep version reference of graphql from 0.11 to 0.12.3 #407

wants to merge 1 commit into from

Conversation

Choongkyu
Copy link

No description provided.

@@ -92,6 +92,6 @@
"supertest": "3.0.0"
},
"peerDependencies": {
"graphql": "^0.10.0 || ^0.11.0"
"graphql": "^0.12.3 || ^0.10.0 || ^0.11.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be ^0.12.0 because it will include all 0.12.x versions

graingert added a commit to graingert/express-graphql that referenced this pull request Jan 17, 2018
This is a fixed version of graphql#407
@graingert graingert mentioned this pull request Jan 17, 2018
graingert added a commit to graingert/express-graphql that referenced this pull request Jan 17, 2018
This is a fixed version of graphql#407

also update tests with the new graphql error messages.
@magic890
Copy link

@SimonDegraeve when is going to be released the package on npm registry with this fix?

@SimonDegraeve
Copy link
Contributor

@magic890 I am not involved in this repository. Sorry.

@magic890
Copy link

@IvanGoncharov @wincent any on this update?

@IvanGoncharov
Copy link
Member

@magic890 This PR both specify an incorrect version and failing test but #411 fixes all those issues.
As for progress overall, I don't have commit rights to this repo and @wincent moved to another project so I don't know if he would be able to review #411.

I think I already pinged the right person in #411 so it should be merged in a few days.

@zebralight Can you please close this PR in favor of #411 since it will help to solve confusion?

@IvanGoncharov
Copy link
Member

@zebralight I merged #411 so I closing this PR.

@magic890 I already added both 0.12.x and 0.13.x as peer dependences and preparing a new release of NPM package.

@IvanGoncharov
Copy link
Member

@zebralight @magic890 @SimonDegraeve 0.6.12 📦 released with support for graphql v0.12.x and v0.13.x.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants