-
Notifications
You must be signed in to change notification settings - Fork 538
update peer dep version reference of graphql from 0.11 to 0.12.3 #407
Conversation
@@ -92,6 +92,6 @@ | |||
"supertest": "3.0.0" | |||
}, | |||
"peerDependencies": { | |||
"graphql": "^0.10.0 || ^0.11.0" | |||
"graphql": "^0.12.3 || ^0.10.0 || ^0.11.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be ^0.12.0
because it will include all 0.12.x
versions
This is a fixed version of graphql#407
This is a fixed version of graphql#407 also update tests with the new graphql error messages.
@SimonDegraeve when is going to be released the package on npm registry with this fix? |
@magic890 I am not involved in this repository. Sorry. |
@IvanGoncharov @wincent any on this update? |
@magic890 This PR both specify an incorrect version and failing test but #411 fixes all those issues. I think I already pinged the right person in #411 so it should be merged in a few days. @zebralight Can you please close this PR in favor of #411 since it will help to solve confusion? |
@zebralight I merged #411 so I closing this PR. @magic890 I already added both |
@zebralight @magic890 @SimonDegraeve |
No description provided.