New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate input array type definitions as $ReadOnlyArray<> #125

Closed

rwe opened this issue Dec 17, 2017 · 1 comment

rwe commented Dec 17, 2017

DataLoader doesn't modify input arrays, and it can be helpful to annotate that in the type definitions:

-type BatchLoadFn<K, V> = (keys: Array<K>) => Promise<Array<V | Error>>;
+type BatchLoadFn<K, V> = (keys: $ReadOnlyArray<K>) => Promise<Array<V | Error>>;

-  loadMany(keys: Array<K>): Promise<Array<V>> {
+ loadMany(keys: $ReadOnlyArray<K>): Promise<Array<V>> {

etc.

Author

rwe commented Dec 20, 2017

Woops! Looks like this was done in #100 and I was just looking at an old tag's source.

rwe closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment