Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing comments in query causes "string index out of range" #39

Closed
andrewspode opened this issue Jun 19, 2019 · 1 comment
Closed
Assignees
Labels
bug Something isn't working

Comments

@andrewspode
Copy link

I'm using graphiQL for testing my API where it is fairly common practice to comment out a query and write a new one.

{info}

Will run fine.

{info}
#

Will fail with "string index out of range" on line 268 of lexer.py (char=body[position])

I could be wrong - but shouldn't that be a >= rather than >?

@Cito Cito added the investigate Needs investigaton or experimentation label Jun 30, 2019
@Cito Cito self-assigned this Jun 30, 2019
@Cito Cito added bug Something isn't working and removed investigate Needs investigaton or experimentation labels Jul 6, 2019
@Cito
Copy link
Member

Cito commented Jul 6, 2019

Thank you for the bug report, @andrewspode . You are right, that should be a >=.

@Cito Cito closed this as completed in 428f3d8 Jul 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants