Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subscribe breaking change in graphql version 3.3.0a3 #202

Closed
leszekhanusz opened this issue Jun 4, 2023 · 1 comment
Closed

subscribe breaking change in graphql version 3.3.0a3 #202

leszekhanusz opened this issue Jun 4, 2023 · 1 comment

Comments

@leszekhanusz
Copy link

It seems we don't need to use await anymore with the subscribe method since the latest 3.3.0a3 pre-release.

This causes current gql tests to fail with either:

  • TypeError: object async_generator can't be used in 'await' expression
  • TypeError: object ExecutionResult can't be used in 'await' expression

That new interface seems cleaner but could you please maybe indicate that breaking change in the release notes?

Thanks,

@Cito
Copy link
Member

Cito commented Jun 5, 2023

Right, this is a breanking change that is now mentioned in the release notes. It mirrors a similar change in GraphQL.js.

@Cito Cito closed this as completed Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants