Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graphql-server-core==2.0.0 is compatible #22

Open
blazewicz opened this issue May 12, 2020 · 1 comment
Open

graphql-server-core==2.0.0 is compatible #22

blazewicz opened this issue May 12, 2020 · 1 comment

Comments

@blazewicz
Copy link

I'm guessing that graphql-server-core>2 was expected to follow v3 and thus breaking compatibility with v2 based projects. Meanwhile @jkimbo published v2.0.0 without any breaking changes, making following line of setup.py outdated:

aiohttp-graphql/setup.py

Line 27 in a7aa6c6

"graphql-server-core>=1.2,<2",

@KingDarBoja
Copy link
Contributor

Hi @blazewicz

This package will get merged into graphql-server-core as optional in order to avoid these breaking changes everytime the library is being update.

To stay update with the current status, please check this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blazewicz @KingDarBoja