-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"starwars" example currently broken #28
Comments
#29 fixed this for me. Has not been merged yet. |
That's a more complete solution too. Thanks for the heads up. |
In the obscure case of them actually progressing, it can't hurt to emphasize a specific bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have a handler PR that's failing in Travis because of the starwars example. It looks like the signature of the type-resolver function (ResolveTypeFn) changed here.
The signature of ResolveTypeFn is now "(p ResolveTypeParams) *Object" but the function is currently defined as:
As a result, the test is currently showing:
I'm not in a place that I can currently fix it. I also risk destabilizing the example because I believe you can now get the content of the old
value
argument from the newp
(ResolveTypeParams) argument but I am new to GraphQL and don't know that I can effectively test it before committing.The text was updated successfully, but these errors were encountered: