Skip to content
This repository has been archived by the owner on Mar 9, 2023. It is now read-only.

Feature request - add redirect for non-existing views #250

Open
koen84 opened this issue Dec 11, 2020 · 2 comments
Open

Feature request - add redirect for non-existing views #250

koen84 opened this issue Dec 11, 2020 · 2 comments

Comments

@koen84
Copy link

koen84 commented Dec 11, 2020

If the profile view is something it something that doesn't exist (currently overview, subgraphs, curating, indexing & delegating) it displays a "blank" page. I think it would be wise to "redirect" to overview as "default" action.

Could be from a typo, could be an outdated bookmark, etc.

Example : https://testnet.thegraph.com/profile/?id=0x535ecc66fbed721507f41a686d867345cb6ac27e&view=NenaWillFix

@trader-payne
Copy link

I don't understand what's the behavior. Did you just replace the view with something of your own and it shows a blank page? Or was that there?

@koen84
Copy link
Author

koen84 commented Dec 11, 2020

Yes, i made up something random. (Came from typing wrong capitalisation on the other bug.)

The views are probably a case statement, but default isn't defined (or filled as no content). My suggestion is to make that go to "overview". The reason is mostly future proofing, in case something gets changed. Though in copy pasting things might go wrong as well.

It's nothing critical, it's simply a bit more graceful imho.

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants