Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .gitignore and split up the subgraph name cli entry command #391

Closed
davekaj opened this issue Nov 12, 2019 · 5 comments
Closed

Add .gitignore and split up the subgraph name cli entry command #391

davekaj opened this issue Nov 12, 2019 · 5 comments
Labels
enhancement New feature or request p3

Comments

@davekaj
Copy link
Contributor

davekaj commented Nov 12, 2019

I noticed at Eth waterloo that no .gitignore gets created. We should ignore the ./generated folder, and node modules.

Also, one of our users kept trying to enter just a subgraph name, and would then be told to do /username/subgraphname . Would it make more sense to split this into two commands?

@Jannis
Copy link
Contributor

Jannis commented Nov 12, 2019

I'm not sure I understand that second part. Creating a .gitignore makes a ton of sense though.

@Jannis Jannis added p3 enhancement New feature or request labels Nov 12, 2019 — with Leander Project
@davekaj
Copy link
Contributor Author

davekaj commented Nov 12, 2019

Second part would be instead of the cli prompt

please enter your subgraph name:

and the user is supposed to know it is <YOUR_GITHUB_HANDLE> / subgraph name

It would be

please enter your github handle

And then :

please enter your subgraph name

And then we compose it for them and let them know that their subgraph name is a combination of the two

I think this is a slightly better UX

@Jannis
Copy link
Contributor

Jannis commented Nov 13, 2019

Ah, that's fair enough, we can think about how to do this best.

@Jannis
Copy link
Contributor

Jannis commented Nov 14, 2019

Maybe what we should do is

Subgraph name (e.g. `githubuser/mydao`):

Because Please enter your subgraph name might suggest to people that they should type in e.g. My DAO or something, not the URL handle for the subgraph.

@davekaj
Copy link
Contributor Author

davekaj commented Nov 14, 2019

Yeah I like that idea

@azf20 azf20 added this to Tooling Mar 8, 2023
@azf20 azf20 closed this as completed Mar 9, 2023
@github-project-automation github-project-automation bot moved this to ✅ Done in Tooling Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request p3
Projects
Status: Done
Development

No branches or pull requests

3 participants