[WIP] Horizon: fix unit tests and refactor #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[WIP] Horizon: fix unit tests and refactor
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Maikol
force-pushed
the
mde/fix-escrow-and-payments-tests
branch
from
e3d164d
to
85a6f9d
Compare
Maikol
force-pushed
the
mde/fix-escrow-and-payments-tests
branch
from
2fab1d6
to
8947c07
Compare
tmigone
reviewed
May 23, 2024
| @@ -16,6 +16,7 @@ import { IGraphProxyAdmin } from "@graphprotocol/contracts/contracts/upgrades/IG | |||
|
|
|||
| import { ICuration } from "@graphprotocol/contracts/contracts/curation/ICuration.sol"; | |||
|
|
|||
| import "forge-std/console.sol"; | |||
| uint256 tokensReceiverRemaining = tokens - tokensProtocol - tokensDataService - tokensDelegationPool; | ||
| uint256 totalCut = tokensProtocol + tokensDataService + tokensDelegationPool; | ||
| if (totalCut > tokens) { | ||
| revert GraphPaymentsCollectorInsufficientAmount(tokens, totalCut); |
There was a problem hiding this comment.
Not sure I would use the term Collector here, how about just:
Suggested change
| revert GraphPaymentsCollectorInsufficientAmount(tokens, totalCut); | |
| revert GraphPaymentsInsufficientTokens(tokens, totalCut); |
| @@ -78,14 +78,19 @@ contract PaymentsEscrow is Multicall, GraphDirectory, IPaymentsEscrow { | |||
| revert GraphEscrowThawingPeriodTooLong(withdrawEscrowThawingPeriod, MAX_THAWING_PERIOD); | |||
| } | |||
|
|
|||
| revokeCollectorThawingPeriod = revokeCollectorThawingPeriod; | |||
| withdrawEscrowThawingPeriod = withdrawEscrowThawingPeriod; | |||
| REVOKE_COLLECTOR_THAWING_PERIOD = revokeCollectorThawingPeriod; | |||
There was a problem hiding this comment.
haha I was so confused for a moment
tmigone
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.