Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update EIP712_ALLOCATION_PROOF_TYPEHASH from variable to constant. (OZ N-06) #1035

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

MoonBoi9001
Copy link
Member

Motivation:

Title:

N-06 Variable Could Be constant

Details:

If a variable is only ever assigned a value when it is declared, then it could be declared as constant.

The EIP712_ALLOCATION_PROOF_TYPEHASH state variable could be constant.

To better convey the intended use of variables, consider adding the constant keyword to variables that are only set when they are declared.

Key changes

  • Updated EIP712_ALLOCATION_PROOF_TYPEHASH to be a constant

Copy link

fix: update EIP712_ALLOCATION_PROOF_TYPEHASH from variable to constant. (OZ N-06)

Generated at commit: a58f807db20d1b7e82c0502a1995cd676d168fb2

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
4
0
15
41
62
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

Copy link
Contributor

@tmigone tmigone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💎

@MoonBoi9001 MoonBoi9001 merged commit ff7a0ed into horizon Sep 20, 2024
7 checks passed
@MoonBoi9001 MoonBoi9001 deleted the fix_oz_n-06 branch September 20, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants