Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-key src/dst shapings ignore all keys after the first #52

Open
lmeyerov opened this issue May 10, 2022 · 2 comments
Open

Multi-key src/dst shapings ignore all keys after the first #52

lmeyerov opened this issue May 10, 2022 · 2 comments
Assignees
Labels
bug Something isn't working P4

Comments

@lmeyerov
Copy link
Contributor

When multiple fields are put in for the src/dst, only the first is used

Ex: src = [ VP, Region ] should cause nodes like (Jane, USA) but instead only creates node Jane
Screenshot from 2022-05-10 16-24-45

@lmeyerov lmeyerov added bug Something isn't working P4 labels May 10, 2022
@dess890
Copy link
Contributor

dess890 commented Jun 10, 2022

lines 47-52 needs to be removed in capabilities.json
"drilldown": { "roles": [ "Source", "Target" ] },

@dess890
Copy link
Contributor

dess890 commented Jun 10, 2022

need to implement .filter and map instead of .find in visual.ts

line 160
const srcColMetadata = view.metadata.columns.find((c) => c.roles.Source);

line 163
const dstColMetadata = view.metadata.columns.find((c) => c.roles.Destination);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P4
Projects
None yet
Development

No branches or pull requests

2 participants