Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V5: forbid addBehaviorToTags (or at least use it less) #1762

Closed
benjie opened this issue Sep 27, 2023 · 0 comments · Fixed by #2160
Closed

V5: forbid addBehaviorToTags (or at least use it less) #1762

benjie opened this issue Sep 27, 2023 · 0 comments · Fixed by #2160
Labels
🐛 bug

Comments

@benjie
Copy link
Member

benjie commented Sep 27, 2023

e.g. https://github.com/graphile/crystal/blob/main/graphile-build/graphile-build-pg/src/plugins/PgIndexBehaviorsPlugin.ts#L52C17-L52C53

This should be using the "inferred" behavior system, not modifying the behaviors the user has specified.
@benjie benjie added this to V5.0.0 Oct 4, 2023
@github-project-automation github-project-automation bot moved this to 🌳 Triage in V5.0.0 Oct 4, 2023
@benjie benjie moved this from 🌳 Triage to 🦟 Mayfly in V5.0.0 Oct 4, 2023
@benjie benjie mentioned this issue May 10, 2024
Closed
@benjie benjie mentioned this issue Aug 17, 2024
Merged
11 tasks
@github-project-automation github-project-automation bot moved this from 🦟 Mayfly to ✅ Done in V5.0.0 Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug
Projects
V5.0.0
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stage 1 of behavior overhaul graphile/crystal
1 participant
@benjie