Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support avg reading of DiFluid R2 TDS #733

Open
graphefruit opened this issue Jun 22, 2024 · 3 comments
Open

Support avg reading of DiFluid R2 TDS #733

graphefruit opened this issue Jun 22, 2024 · 3 comments

Comments

@graphefruit
Copy link
Owner

No description provided.

@zshenker
Copy link

zshenker commented Dec 1, 2024

Would you be open to a PR for this feature?

If so, any thoughts on how you are thinking this would work? Initially I'm thinking that hitting the test button would take a measurement and rather than replace the previous keep track of all values and update the average as the value stored.

Only thing that I'm thinking could be useful is some way to ignore/drop certain tests as I've found sometimes if I haven't let the sample cool enough a measurement can be a bit out of range from what I see on a later test. Maybe enough samples averaged out would account for one being off?

@zshenker
Copy link

zshenker commented Dec 2, 2024

@graphefruit ^

@graphefruit
Copy link
Owner Author

Would you be open to a PR for this feature?

Definitely.

If so, any thoughts on how you are thinking this would work? Initially I'm thinking that hitting the test button would take a measurement and rather than replace the previous keep track of all values and update the average as the value stored.
If I'm correct from the API its possible to do a single test or a multiple test: https://github.com/DiFluid/difluid-sdk-demo/blob/master/docs/protocolR2.md

From my perspective: I'd let the user choose what he would like to test, single or avg and then write the value to the field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants