-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support new graphql-ws subprotocol #38
Comments
@Quantumplation this would indeed be very helpful. PRs are more than welcome. |
@pavelnikolov Super swamped with work right now, but I might have some spare time in a week or two! |
Cross-ref hasura/go-graphql-client#38. As of now I'm totally lost with old vs new. Seems the Go landscape has server, but is missing client support for the "new" |
https://github.com/hasura/go-graphql-client meanwhile has support, too. |
@andig but this this client only library, right? Not server websocket handler for gophers graphql? |
Any progress for this issue |
Note that I am aware of. |
At some point, the graphql community made the breaking change to switch to a new websocket subprotocol; What was previously called the
graphql-ws
subprotocol is now calledgraphql-transport-ws
. N.B. Confusingly, the standard library implementing this in the js world is calledgraphql-ws
, making this non-trivial to track down, as I kept thinking that graphql-ws was the more modern one.It would be super helpful to support the new spec.
See:
https://www.apollographql.com/docs/apollo-server/data/subscriptions/#switching-from-subscriptions-transport-ws
https://github.com/enisdenjo/graphql-ws/tree/master/docs
https://github.com/enisdenjo/graphql-ws/blob/d44c6f18ccd2bc539bb541e6bfd1bf0c769c7856/src/common.ts#L10-L15
The text was updated successfully, but these errors were encountered: