-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Assertions + Modularize #173
Refactor: Assertions + Modularize #173
Conversation
This looks great, thanks. I should be able to do a proper review this evening. |
I just cloned this PR locally and am running into several test errors when I run Quick example of a failing test from pkgload::load_all("~/Documents/Projects/tinyplot")
#> ℹ Loading tinyplot mtcars$am = as.factor(mtcars$am)
with(mtcars, tinyplot(mpg, by = am, type = "density", legend = list(x = "bottom!")))
#> Error in legend(x = list, x = "bottom!", title = "am", lty = c("solid", : formal argument "x" matched by multiple actual arguments Created on 2024-07-22 with reprex v2.1.0 |
Right, your example fails for me locally too. Should be a simple issue with legend. Will look into it soon. |
But it should fail as part of the GH Actions CI too, right?? Or am I just missing something? (I was panicking that the workflow file isn't running any tests---maybe due to an env var mishap---but I just confirmed that it is via #174, which intentionally pushes a failing test. I'm honestly stumped why this PR isn't yielding a bunch of failed jobs in its current state.) |
FYI,
|
Ah, good catch. That's a tricky bug. But I'm happy for you to implement the workaround that you suggested. |
This comment was marked as resolved.
This comment was marked as resolved.
111a027
to
5a2b246
Compare
@grantmcdermott forget about my last post. I made a stupid mistake. When fixed, and with your boxplot commit merged, everything passes as expected. |
Excellent thanks. I'll take a look after dinner. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really great @vincentarelbundock.
I've dropped some (mostly minor) request changes and clarification questions. Could you take a stab at actioning these and let me know once the revision is ready? Thanks!
I think everything is resolved. Only discussion points are: copyleft issue (probably OK, I think) and warning on automagic |
Thanks for all the hard work on this! The main script was becoming increasingly unwieldy. So I'm very grateful that you took on the hard work of modularizing everything. 🎉🚀 I'll add NEWS item with attribution once I get time this evening. |
The goals of this PR are:
type
-specific transformations and settings together intinyplot.R
. This will make it easier to insert new types.type
-specific transformations and settings to separate files and functions. For readability and maintainability.facet_layout()
draw_element()
assertions.R
that I use intinytable
. It basically re-implementscheckmate
package assertions without dependencies. We don't get much out of this now, but eventually this should give us: