-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more parsers #53
base: main
Are you sure you want to change the base?
Add more parsers #53
Conversation
In github action, tree-sitter and npm will be installed to fix this problem. |
tree-sitter/py-tree-sitter#189 affect many parsers. |
Now it can work |
Big BUMP to have this PR integrated. Aider with Swift support would rock. |
Any updated what would be required to merge/approve this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would love to have this merged as well! Left a small comment.
Moreover, would it make sense to first just move to this new approach of handling parsers and only later add additional parsers so that the two things can be reviewed in an easier/more thorough way?
Great work anyway :)
@Freed-Wu
Is this because something is wrong with the downstream of the |
Can you disable wing then try again? |
Whatever git commit you locking down the build step to should be tested across multiple archs and os. Maybe try to build through gh actions in a separate branch. |
I think I saw a similar error with newer tree sitter on another project |
Use parsers.json and lockfile.json to get information required by Language.build_library() Add .github/workflows/update.yml to update parsers.json and lockfile.json Co-authored-by: Riccardo Schirone <[email protected]>
I have updated and now I haven't found any error.
Wait @grantjenks on #54 |
@Freed-Wu can you clarify something for me? Can you adjust this project to run the That way we can just include this repo in the |
@cmosguy I believe that is out of the scope of this project. From README:
This project aims to provide precompiled tree sitter packages so you don't need to depend on a C compiler. |
Thanks @sansmoraxz - I think I am confused then. The pipeline for this project compiles and generates My point is that because @grantjenks has absconded from this project, we need someone to basically take over the reigns now and create a new project repo and PiPy project so that others can use these python bindings. A github action workflow will build the What do you say @Freed-Wu ? Maybe create a whole new repo since @grantjenks is not interested in this anymore? |
Okay, on the basis of "if nobody does anything then nothing will happen" (and also cause I really wanted aider D support), I've created a new Python package called 'tree-sitter-languages-freed-wu-pr' https://pypi.org/project/tree-sitter-languages-freed-wu-pr/ https://github.com/FeepingCreature/py-tree-sitter-languages It changes the package name to tree_sitter_languages_freed_wu_pr to avoid collisions with this repo. I don't know what @grantjenks or @Freed-Wu are up to, or if they're going to come back to this, but that should at least let other projects move forward for now. I'm not committing to maintaining it. I'm especially not committing to maintaining it after the forty attempts to get the Github release action to work. But hopefully it should work at least as well as the last official release. Changes from this PR:
But otherwise, ie. on Linux and Mac, all the languages from this PR should be in there and working. If you want, you can look at the failed build actions here. |
Use parsers.json and lockfile.json to get information required by Language.build_library()
Add .github/workflows/update.yml to update parsers.json and lockfile.json
Continue #33
@sansmoraxz lockfile.json lock the commit