From 1d558872d14219cfd85e26b79d9d8c323efe85ea Mon Sep 17 00:00:00 2001 From: Grant Nicholas Date: Tue, 18 Jan 2022 11:51:55 -0600 Subject: [PATCH] Remove dangling TODO that links to a resolved issue The upstream issue: https://github.com/trinodb/trino/issues/9021 cannot be reproduced, see the issue for details --- .../main/java/io/trino/plugin/jdbc/DefaultJdbcMetadata.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/DefaultJdbcMetadata.java b/plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/DefaultJdbcMetadata.java index ef6eb94180c38..103449eeb4608 100644 --- a/plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/DefaultJdbcMetadata.java +++ b/plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/DefaultJdbcMetadata.java @@ -311,8 +311,7 @@ public Optional> applyAggrega List newColumnsList = newColumns.build(); - // TODO(https://github.com/trinodb/trino/issues/9021) We are reading all grouping columns from remote database as at this point we are not able to tell if they are needed up in the query. - // As a reason of that we need to also have matching column handles in JdbcTableHandle constructed below, as columns read via JDBC must match column handles list. + // We need to have matching column handles in JdbcTableHandle constructed below, as columns read via JDBC must match column handles list. // For more context see assertion in JdbcRecordSetProvider.getRecordSet PreparedQuery preparedQuery = jdbcClient.prepareQuery( session,