Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible dependencies #421

Closed
Samurai336 opened this issue Aug 18, 2023 · 9 comments
Closed

Incompatible dependencies #421

Samurai336 opened this issue Aug 18, 2023 · 9 comments

Comments

@Samurai336
Copy link
Contributor

Samurai336 commented Aug 18, 2023

There is a dependency conflict when trying to install grapmps-webapi dependencies.

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
flake8 5.0.4 requires importlib-metadata<4.3,>=1.1.0; python_version < "3.8", but you have importlib-metadata 4.13.0 which is incompatible.

Did the following to get this issue on Linux Mint:

Once repository is cloned

  1. In grapmps-webapi project root setup a new virtual environment set to python 3.7 and activate environment. I used pyenv with pyenv-virtualenv plugin

  2. Edit your virtual environments pyvenv.cfg file (for me it was in ~/.pyenv/versions//pyvenv.cfg) to set include-system-site-packages to True and save.

  3. Install dev dependencies pip install -r requirements-dev.txt

  4. Install gramps-webapi and dependencies pip3 install -e .

This should create the conflict error listed above. Not using --user on the editable dependency install because it in the virtual environment it would create a lack of sys.path precedence to gramps-webapi (see pypa/pip#573)

@Samurai336
Copy link
Contributor Author

python3.8 does not have this dependency conflict so does the project need to up its python dependency requirement?

@DavidMStraub
Copy link
Member

Can you try updating flake8? It's just a development dependency without version pin...

@Samurai336
Copy link
Contributor Author

it installs but I get an error warning me

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
gramps-webapi 1.1.8 requires importlib-metadata==4.13.0, but you have importlib-metadata 4.2.0 which is incompatible.

@DavidMStraub
Copy link
Member

Ok. The version pin was added because of this issue python/importlib_metadata#411 which caused builds to fail on 3.7. Can you please try what happens when you remove the version pin in Web API?

@Samurai336
Copy link
Contributor Author

I don't get a dependency conflict when I remove the pin from the setup.py. pip says it now has 4.2.0 of importlib-metadata installed

@DavidMStraub
Copy link
Member

Cool, perhaps the bug has been fixed. Do you want to submit a PR?

@Samurai336
Copy link
Contributor Author

I am still having precommit issues. Trying to resolve that is how I ran into this. :)

@Samurai336
Copy link
Contributor Author

You'll have to check me because I just did --no-verify

@DavidMStraub
Copy link
Member

Fixed by #422.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants