This repository has been archived by the owner on May 25, 2024. It is now read-only.
fix: provide explicit error message for invalid token #25
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-withAshish
had a problem deploying
to
preview
GitHub Actions
Failure
rojvv
reviewed
Sep 1, 2023
| <span class="text-lg font-bold">An error has occured</span> | ||
| <p class="text-sm">There was an unexpected error. Check the details below:</p> | ||
| <pre class="mt-3 bg-background">{{ JSON.stringify(error, null, 2) }}</pre> | ||
| <pre class="mt-3 break-all bg-background" v-if="error.stack?.includes('getMe')"> |
There was a problem hiding this comment.
Broad as in?
There was a problem hiding this comment.
I know
I mentioned that it's hacky because as of now there's no way to detect of the error is from getMe method, blso either we use a .catch with the getMe method and catch the errors of that method seperately or do some hacks.
code-withAshish
had a problem deploying
to
preview
GitHub Actions
Failure
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier the error message for invalid token was very general and stated
HTTP error, this PR fixes this by checking the error stack if it contains the error fromgetMemethod then concludes either of two errors have occured:-It's somewhat hacky to say the least but i think it gets the work done.
fixes #10