Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: let ctx.session be undefined for missing session keys #713

Open
Tracked by #675
KnorpelSenf opened this issue Dec 15, 2024 · 1 comment
Open
Tracked by #675

feat: let ctx.session be undefined for missing session keys #713

KnorpelSenf opened this issue Dec 15, 2024 · 1 comment

Comments

@KnorpelSenf
Copy link
Member

KnorpelSenf commented Dec 15, 2024 •
edited
Loading

The fact that an error is thrown upon property access is really annoying. There is no good way of knowing whether session data exists, so we should change this behaviour.
@KnorpelSenf KnorpelSenf mentioned this issue Dec 15, 2024
Open
48 tasks
@KnorpelSenf KnorpelSenf changed the title feat: let ctx.session be undefined for missing sessions feat: let ctx.session be undefined for missing session keys Dec 18, 2024
@KnorpelSenf
Copy link
Member Author

We should probably still throw an error upon assignment to ctx.session

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KnorpelSenf