You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the current implementation in gsc.py, we add all CLI arguments into the environment, which may create conflicting names(variables passed from command line and internal variables used in script). Based on the discussion in PR #144 below solution need to applied across gsc.py.
add explicit '--define', '-D' option similar to what we have in gramine-manifest that would accept key=value pairs which are added to globals (and only those); then if you prefer, add e.g. --remove-gramine-deps as an alias for -Dremove_gramine_deps=true;
add whole namespace as a single object (env.globals['args'] = args) and use those as {% if args.flag %}. Because that's namespace, there will be a less risk of a collision.
Expected results
All gsc subcommands and options should work as it is.
The text was updated successfully, but these errors were encountered:
In the current implementation in
gsc.py
, we add all CLI arguments into the environment, which may create conflicting names(variables passed from command line and internal variables used in script). Based on the discussion in PR #144 below solution need to applied acrossgsc.py
.'--define', '-D'
option similar to what we have ingramine-manifest
that would acceptkey=value
pairs which are added to globals (and only those); then if you prefer, add e.g.--remove-gramine-deps
as an alias for-Dremove_gramine_deps=true
;env.globals['args'] = args
) and use those as{% if args.flag %}
. Because that's namespace, there will be a less risk of a collision.Expected results
All gsc subcommands and options should work as it is.
The text was updated successfully, but these errors were encountered: