Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement namespace separation for all GSC sub-commands gsc build, build-gramine and sign-image. #150

Open
amathew3 opened this issue May 22, 2023 · 0 comments

Comments

@amathew3
Copy link
Contributor

amathew3 commented May 22, 2023

In the current implementation in gsc.py, we add all CLI arguments into the environment, which may create conflicting names(variables passed from command line and internal variables used in script). Based on the discussion in PR #144 below solution need to applied across gsc.py.

  • add explicit '--define', '-D' option similar to what we have in gramine-manifest that would accept key=value pairs which are added to globals (and only those); then if you prefer, add e.g. --remove-gramine-deps as an alias for -Dremove_gramine_deps=true;
  • add whole namespace as a single object (env.globals['args'] = args) and use those as {% if args.flag %}. Because that's namespace, there will be a less risk of a collision.

Expected results

All gsc subcommands and options should work as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant