Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes 1.16 support #434

Closed
gmathes opened this issue Dec 27, 2019 · 11 comments
Closed

Kubernetes 1.16 support #434

gmathes opened this issue Dec 27, 2019 · 11 comments
Assignees

Comments

@gmathes
Copy link

gmathes commented Dec 27, 2019

Is your feature request related to a problem? Please describe.
Kritis v0.2.0 does not seem to be compatible with Kubernetes version 1.16

Error: unable to build kubernetes objects from release manifest: [unable to recognize "": no matches for kind "Deployment" in version "apps/v1beta2", error validating "": error validating data: ValidationError(ClusterRole.metadata): unknown field "kritis.grafeas.io/install" in io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta]

Describe the solution you'd like
Updated helm charts that support the newer APIs and CRD definitions
https://kubernetes.io/blog/2019/09/18/kubernetes-1-16-release-announcement/

Describe alternatives you've considered
We are manually updating our own deployment files to meet the requirements for 1.16

Additional context
This is more for awareness. I don't think GKE supports 1.16 yet but others might be using Kritis in a non-GKE environment.

@judavi
Copy link
Contributor

judavi commented Jan 3, 2020

@gmathes would you mind to share what kind of changes you need to apply to make it work? I'm struggling to understand what are the errors : #428 (comment)

@judavi
Copy link
Contributor

judavi commented Jan 3, 2020

Actually, I doubled checked and I'm running 1.14 and I'm having the same issue, so in some point between 1.9 and 1.14 the helm chart stopped working

@nenaddedic
Copy link
Contributor

I think this requires bumping the kubectl version in https://github.com/grafeas/kritis/blob/master/helm-hooks/Dockerfile and re-releasing.

@aysylu
Copy link
Contributor

aysylu commented Jan 7, 2020

This should be fixed in the upcoming 0.2.1 release in #444.

@aysylu
Copy link
Contributor

aysylu commented Jan 9, 2020

The 0.2.1 release is out. Please re-open this issue if it's still not fixed in the new release. Thanks!

@aysylu aysylu closed this as completed Jan 9, 2020
@gmathes
Copy link
Author

gmathes commented Jan 9, 2020

The deployment is still using a deprecated API:

helm install https://storage.googleapis.com/kritis-charts/repository/kritis-charts-0.2.1.tgz --generate-name

Error: unable to build kubernetes objects from release manifest: unable to recognize "": no matches for kind "Deployment" in version "apps/v1beta2"

@nenaddedic
Copy link
Contributor

This should be fixed in 0.2.2. Please re-open if still broken.

@gmathes
Copy link
Author

gmathes commented Jan 14, 2020

Thanks for tackling this. Maybe I'm doing something wrong but it seems the pre-install is still failing against a 1.16 minikube cluster:

level=error msg="The CustomResourceDefinition \"attestationauthorities.kritis.grafeas.io\" is invalid: status.storedVersions[0]: Invalid value: \"v1\": must appear in spec.versions\n"

@nenaddedic
Copy link
Contributor

Are you installing it into a "fresh" cluster? Or have you already done something Kritis-related in that cluster?

@nenaddedic nenaddedic reopened this Jan 14, 2020
@gmathes
Copy link
Author

gmathes commented Jan 16, 2020

Ah, yes, this works on a fresh cluster.

@gmathes gmathes closed this as completed Jan 16, 2020
@aysylu
Copy link
Contributor

aysylu commented Jan 16, 2020

Thanks for confirming, @gmathes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants