From 2e397cbefba98f055a665351facd47fed75167ae Mon Sep 17 00:00:00 2001 From: Mihail Stoykov <312246+mstoykov@users.noreply.github.com> Date: Wed, 5 Jul 2023 16:45:18 +0300 Subject: [PATCH 1/2] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 01c1143..012761b 100644 --- a/README.md +++ b/README.md @@ -106,7 +106,7 @@ $ xk6 build [] [--replace ...] ``` -- `` is the core k6 version to build; defaults to `K6_VERSION` env variable or latest. +- `` is the core k6 version to build; defaults to `K6_VERSION` env variable or whatever is the latest version needed by all extensions. - `--output` changes the output file. - `--with` can be used multiple times to add extensions by specifying the Go module name and optionally its version, similar to `go get`. Module name is required, but specific version and/or local replacement are optional. For an up-to-date list of k6 extensions, head to our [extensions page](https://k6.io/docs/extensions/). - `--replace` can be used multiple times to add replacements by specifying the Go module name and the replacement module, similar to `go mod edit -replace=`. Version of the replacement can be specified with the `@version` suffix in the replacement path. From 12b68cf9dfb93827a1c886bcd1855b3f06ba1973 Mon Sep 17 00:00:00 2001 From: Mihail Stoykov <312246+mstoykov@users.noreply.github.com> Date: Wed, 5 Jul 2023 17:04:19 +0300 Subject: [PATCH 2/2] Apply suggestions from code review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Ivan Mirić --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index 012761b..8c09e7e 100644 --- a/README.md +++ b/README.md @@ -107,6 +107,7 @@ $ xk6 build [] ``` - `` is the core k6 version to build; defaults to `K6_VERSION` env variable or whatever is the latest version needed by all extensions. + For example, if extension A requires k6 v0.41.0 and extension B requires k6 v0.43.0, the final k6 version used in the binary will be v0.43.0. Note that depending on the differences in these versions, this behavior might cause the build to fail. This is something enforced by the Go build system, and we have no way of fixing it. - `--output` changes the output file. - `--with` can be used multiple times to add extensions by specifying the Go module name and optionally its version, similar to `go get`. Module name is required, but specific version and/or local replacement are optional. For an up-to-date list of k6 extensions, head to our [extensions page](https://k6.io/docs/extensions/). - `--replace` can be used multiple times to add replacements by specifying the Go module name and the replacement module, similar to `go mod edit -replace=`. Version of the replacement can be specified with the `@version` suffix in the replacement path.