Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from the direct runtime access throw the go routines #71

Closed
Tracked by #3154
olegbespalov opened this issue Apr 12, 2024 · 0 comments · Fixed by #76
Closed
Tracked by #3154

Migrate from the direct runtime access throw the go routines #71

olegbespalov opened this issue Apr 12, 2024 · 0 comments · Fixed by #76
Assignees

Comments

@olegbespalov
Copy link
Contributor

What?

During the #67 (comment) we figured out that it's essential to not have access to the goja runtime inside the go routines because that could lead to the race.

There are places in the module where we have such access; we should migrate them accordingly:

Why?

Having access to the throw routine could lead to the race.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant