Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop the first argument of the NewError constructor #33

Closed
oleiade opened this issue Mar 28, 2023 · 0 comments · Fixed by #44
Closed

Drop the first argument of the NewError constructor #33

oleiade opened this issue Mar 28, 2023 · 0 comments · Fixed by #44
Assignees
@oleiade
Labels
enhancement New feature or request

Comments

@oleiade
Copy link
Member

oleiade commented Mar 28, 2023

In the current state of the codebase, we use a constructor for WebCrypto errors which is legacy and has an error code we don't really use. We should refactor the constructor to not need the error code, and probably for the error type to not have that code in the first place.

Going from

NewError(0, OperationError, "invalid key length")

To

NewError(OperationError, "invalid key length")

As proposed by [this specific comment](NewError(0, OperationError, "invalid key length")).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleiade oleiade

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the Error code field grafana/xk6-webcrypto
1 participant
@oleiade