From 0f6001344e8d5e97b6f25134a24350aa79658d25 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C4=B0nan=C3=A7=20G=C3=BCm=C3=BC=C5=9F?= Date: Mon, 18 Mar 2024 13:00:33 +0300 Subject: [PATCH] Remove logging in-flight requests We noticed that we shouldn't find an internally failed request as it can cause data race issues within the internal components of the module. Also, we've decided that logging in-flight requests only adds noise without bringing any tangingle value. We keep logging the failed request, though. ... --- common/frame_manager.go | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/common/frame_manager.go b/common/frame_manager.go index fcff99f77..67bc43a45 100644 --- a/common/frame_manager.go +++ b/common/frame_manager.go @@ -447,24 +447,6 @@ func (m *FrameManager) requestFailed(req *Request, canceled bool) { } frame.deleteRequest(req.getID()) - ifr := frame.cloneInflightRequests() - switch rc := len(ifr); { - case rc <= 10: - for reqID := range ifr { - req, ok := frame.requestByID(reqID) - if !ok { - m.logger.Debugf("FrameManager:requestFailed:rc<=10 request is nil", - "reqID:%s frameID:%s", - reqID, frame.ID()) - continue - } - - m.logger.Debugf("FrameManager:requestFailed:rc<=10", - "reqID:%s inflightURL:%s frameID:%s", - reqID, req.URL(), frame.ID()) - } - } - frame.pendingDocumentMu.RLock() if frame.pendingDocument == nil || frame.pendingDocument.request != req { m.logger.Debugf("FrameManager:requestFailed:return", "fmid:%d pdoc:nil", m.ID())