You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While creating a new e2e test in a PR to upgrade k6 with the tagged version of xk6-browser, I found that the test would fail due to an error explained in one of the comments.
Basically the channel isn't being closed here, which is preventing the goroutine from exiting and being cleared away when the test run completes. This will result in a leaked goroutine if the k6 process itself doesn't then shut down.
Once the fix is in place, we need to remember to add the e2e test back in k6.
Brief summary
While creating a new e2e test in a PR to upgrade k6 with the tagged version of xk6-browser, I found that the test would fail due to an error explained in one of the comments.
Basically the channel isn't being closed here, which is preventing the goroutine from exiting and being cleared away when the test run completes. This will result in a leaked goroutine if the k6 process itself doesn't then shut down.
Once the fix is in place, we need to remember to add the e2e test back in k6.
xk6-browser version
v1.0.0
OS
NA
Chrome version
NA
Docker version and image (if applicable)
NA
Steps to reproduce the problem
The steps are outlined in the comment here.
Expected behaviour
The test passes or fails without the
found unexpected goroutines
error.Actual behaviour
The test fails with
found unexpected goroutines
.The text was updated successfully, but these errors were encountered: