Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handleIterEvents goroutines not being cleared up #989

Closed
ankur22 opened this issue Aug 2, 2023 · 0 comments · Fixed by #990
Closed

handleIterEvents goroutines not being cleared up #989

ankur22 opened this issue Aug 2, 2023 · 0 comments · Fixed by #990
Assignees
Labels
bug Something isn't working

Comments

@ankur22
Copy link
Collaborator

ankur22 commented Aug 2, 2023

Brief summary

While creating a new e2e test in a PR to upgrade k6 with the tagged version of xk6-browser, I found that the test would fail due to an error explained in one of the comments.

Basically the channel isn't being closed here, which is preventing the goroutine from exiting and being cleared away when the test run completes. This will result in a leaked goroutine if the k6 process itself doesn't then shut down.

Once the fix is in place, we need to remember to add the e2e test back in k6.

xk6-browser version

v1.0.0

OS

NA

Chrome version

NA

Docker version and image (if applicable)

NA

Steps to reproduce the problem

The steps are outlined in the comment here.

Expected behaviour

The test passes or fails without the found unexpected goroutines error.

Actual behaviour

The test fails with found unexpected goroutines.

@ankur22 ankur22 added the bug Something isn't working label Aug 2, 2023
@ankur22 ankur22 self-assigned this Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant