Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e & test CI workflows #963

Closed
6 tasks done
ankur22 opened this issue Jul 10, 2023 · 0 comments · Fixed by #962
Closed
6 tasks done

Fix e2e & test CI workflows #963

ankur22 opened this issue Jul 10, 2023 · 0 comments · Fixed by #962
Assignees
Labels
bug Something isn't working ci
Milestone

Comments

@ankur22
Copy link
Collaborator

ankur22 commented Jul 10, 2023

This issue is related to the issue with chromium crashing in the test ci workflow. We opened an issue with github and they opened an issue with the chrome team.

In addition to the above, github runner images have both chromium and chrome installed. The browser module defaults to working with chromium over chrome on linux machines. The version of chromium on the github runner images doesn't have the fix to prevent it from crashing, but the version of chrome is up to date.

There are several things to resolve with the workflows:

  1. The test workflow should work with ubuntu-latest.
  2. The exec path for chrome should be set to /usr/bin/google-chrome on linux runners.
  3. The e2e workflow should work with ubuntu-latest.
  4. Use the matrix in the e2e tests. It's defined but then never used.
  5. Remove the install/setup step for linux runners in the test workflow.
  6. Fix any tests that are failing consistently:
    1. The TestBrowserRegistry are very flakey.
    2. The hosts.js example is failing on Windows.

A PR with most to these changes has already been created. What remains are the fixes for the failing (flakey) tests.

Tasks

Preview Give feedback
@ankur22 ankur22 changed the title Fix e2e CI pipeline Fix e2e CI workflow Jul 10, 2023
@ankur22 ankur22 changed the title Fix e2e CI workflow Fix e2e & test CI workflows Jul 10, 2023
@ankur22 ankur22 added the ci label Jul 10, 2023
@ankur22 ankur22 added this to the v0.11.0 milestone Jul 10, 2023
@ankur22 ankur22 assigned ankur22 and unassigned ankur22 Jul 12, 2023
@ankur22 ankur22 added the bug Something isn't working label Jul 13, 2023
@ankur22 ankur22 self-assigned this Aug 10, 2023
@inancgumus inancgumus modified the milestones: v1.0.0, v1.1.0 Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants