New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSModule is already fixed #18

Closed

inancgumus opened this issue Oct 14, 2021 · 0 comments

Labels

Member

inancgumus commented Oct 14, 2021 •

edited

Loading

I'm creating this issue in case we forget to update this code:

xk6-browser/main.go

Lines 37 to 43 in 1e901b4

    
           // JSModule is the entrypoint into the browser JS module 
        
           type JSModule struct { 
        
           	// For when https://github.com/k6io/k6/issues/1802 is fixed 
        
           	//Chromium api.BrowserType 
        
           	Devices map[string]common.Device 
        
           	Version string 
        
           }

It seems like it's already been fixed:

grafana/k6#1802

inancgumus changed the title ~~JSModule is already being fixed~~ JSModule is already fixed

inancgumus added the enhancement label

imiric closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment