Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label spans that have errors attached #1249

Closed
3 tasks done
ankur22 opened this issue Mar 21, 2024 · 1 comment
Closed
3 tasks done

Label spans that have errors attached #1249

ankur22 opened this issue Mar 21, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request remote remote browser related

Comments

@ankur22
Copy link
Collaborator

ankur22 commented Mar 21, 2024

We already have spans for some of our APIs, such as page.screenshot. This allows us to visualise the test run and all the metrics that go along with a particular navigation. What we're currently missing are the errors on the spans. For example, when page.screenshot is called, and an error is received from a remote server (when uploading screenshots to a remote server) we should mark the span with the error.

Tasks

Preview Give feedback
@ankur22 ankur22 added remote remote browser related enhancement New feature or request labels Mar 21, 2024
@ankur22
Copy link
Collaborator Author

ankur22 commented Mar 27, 2024

I think this involves the following calls:

	span.SetStatus(codes.Error, "rate limit reached")
	span.RecordError(errors.New("429: Too Many Requests"))

We need to check the best practices to make sure we're not missing anything.

EDIT

I checked on the otel site and the way that was proposed in the example above it correct -- source.

@ankur22 ankur22 self-assigned this Apr 5, 2024
This was referenced Apr 5, 2024
@ankur22 ankur22 closed this as completed Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request remote remote browser related
Projects
None yet
Development

No branches or pull requests

1 participant