From e7cbc5c10f99915a9eb0e3298dc98c8b7429a31f Mon Sep 17 00:00:00 2001 From: ankur22 Date: Wed, 16 Aug 2023 18:15:54 +0100 Subject: [PATCH] Add skip tip and windows e2e test run The e2e workflow for windows using the tip version of go doesn't seem to work on Windows (or at least in the ci github action). The tip is installed correctly, but when it comes to building the k6 binary using xk6, xk6 seems to always execute the stable version of the go binary and not the tip version. When running commands outside of xk6 to verify the env vars (e.g. GOROOT) it always returns the tip paths. It's unclear why this is happening. For now, we're skipping the windows e2e tip workflow. --- .github/workflows/e2e.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml index 8c350410c..0cf4ea8ed 100644 --- a/.github/workflows/e2e.yml +++ b/.github/workflows/e2e.yml @@ -23,13 +23,15 @@ jobs: runs-on: ${{ matrix.platform }} steps: - name: Checkout code + if: matrix.go != 'tip' || matrix.platform != 'windows-latest' uses: actions/checkout@v2 - name: Install Go + if: matrix.go != 'tip' || matrix.platform != 'windows-latest' uses: actions/setup-go@v2 with: go-version: 1.x - name: Install Go tip - if: matrix.go == 'tip' + if: matrix.go == 'tip' && matrix.platform != 'windows-latest' run: | go install golang.org/dl/gotip@latest gotip download @@ -38,8 +40,10 @@ jobs: echo "$HOME/go/bin" >> "$GITHUB_PATH" echo "$HOME/sdk/gotip/bin" >> "$GITHUB_PATH" - name: Install xk6 + if: matrix.go != 'tip' || matrix.platform != 'windows-latest' run: go install go.k6.io/xk6/cmd/xk6@master - name: Build extension + if: matrix.go != 'tip' || matrix.platform != 'windows-latest' run: | which go go version @@ -49,6 +53,7 @@ jobs: --with github.com/grafana/xk6-browser=. ./k6extension version - name: Run E2E tests + if: matrix.go != 'tip' || matrix.platform != 'windows-latest' run: | set -x if [ "$RUNNER_OS" == "Linux" ]; then @@ -63,5 +68,6 @@ jobs: ./k6extension run "$f" done - name: Check screenshot + if: matrix.go != 'tip' || matrix.platform != 'windows-latest' # TODO: Do something more sophisticated? run: test -s screenshot.png