Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Update asserts for tests to work on OCP 4.18 #1093

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

IshwarKanse
Copy link
Contributor

The Kubernetes job completion status has changed in OCP 4.18

status:
  completionTime: "2024-11-21T05:35:45Z"
  conditions:
  - lastProbeTime: "2024-11-21T05:35:45Z"
    lastTransitionTime: "2024-11-21T05:35:45Z"
    message: Reached expected number of succeeded pods
    reason: CompletionsReached
    status: "True"
    type: SuccessCriteriaMet
  - lastProbeTime: "2024-11-21T05:35:45Z"
    lastTransitionTime: "2024-11-21T05:35:45Z"
    message: Reached expected number of succeeded pods
    reason: CompletionsReached
    status: "True"
    type: Complete
  ready: 0
  startTime: "2024-11-21T05:35:41Z"
  succeeded: 1
  terminating: 0
  uncountedTerminatedPods: {} 

This condition is not available anymore:

status:
  conditions:
    - status: "True"
      type: Complete 

The PR updates the test to use an assert which works both with OCP 4.18 and older OCP versions.

Tested on OCP 4.18

--- PASS: chainsaw (2025.02s)
    --- PASS: chainsaw/ossm-monolithic-otel (333.40s)
    --- PASS: chainsaw/ossm-tempostack (308.51s)
    --- PASS: chainsaw/ossm-tempostack-otel (344.82s)
    --- PASS: chainsaw/otel-tempo-serverless (321.28s)
    --- PASS: chainsaw/tempo-serverless (283.34s)
    --- PASS: chainsaw/monitoring (138.44s)
    --- PASS: chainsaw/monolithic-monitoring (78.07s)
    --- PASS: chainsaw/red-metrics (217.16s)
    --- PASS: chainsaw/gateway (42.39s)
    --- PASS: chainsaw/operator-metrics (17.94s)
    --- PASS: chainsaw/monolithic-single-tenant-auth (77.74s)
    --- PASS: chainsaw/custom-ca (125.00s)
    --- PASS: chainsaw/multitenancy (130.03s)
    --- PASS: chainsaw/compatibility (130.04s)
    --- PASS: chainsaw/tempo-single-tenant-auth (130.68s)
    --- PASS: chainsaw/route (137.07s)
    --- PASS: chainsaw/tempostack-extraconfig (112.89s)
    --- PASS: chainsaw/reconcile (116.98s)
    --- PASS: chainsaw/component-replicas (219.76s)
    --- PASS: chainsaw/monolithic-pv (85.36s)
    --- PASS: chainsaw/monolithic-s3-tls (94.64s)
    --- PASS: chainsaw/generate (11.13s)
    --- PASS: chainsaw/monolithic-receivers-tls (106.51s)
    --- PASS: chainsaw/receivers-tls (125.20s)
    --- PASS: chainsaw/monolithic-memory (78.82s)
    --- PASS: chainsaw/receivers-mtls (131.88s)
    --- PASS: chainsaw/monolithic-ingestion-mtls (71.68s)
    --- PASS: chainsaw/monolithic-extraconfig (52.32s)
    --- PASS: chainsaw/tls-singletenant-monolithic (83.11s)
    --- PASS: chainsaw/monolithic-route (76.91s)
    --- PASS: chainsaw/monolithic-multitenancy-static (84.88s)
    --- PASS: chainsaw/monolithic-multitenancy-openshift (91.09s)
    --- PASS: chainsaw/tls-singletenant (132.01s)
    --- PASS: chainsaw/tempostack-resources (185.62s)
PASS
Tests Summary...
- Passed  tests 34
- Failed  tests 0
- Skipped tests 0

@IshwarKanse IshwarKanse changed the title Update asserts for tests to work on OCP 4.18 [Chore] Update asserts for tests to work on OCP 4.18 Nov 21, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.91%. Comparing base (1fb2623) to head (4ec835a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1093   +/-   ##
=======================================
  Coverage   67.91%   67.91%           
=======================================
  Files         110      110           
  Lines        8728     8728           
=======================================
  Hits         5928     5928           
  Misses       2503     2503           
  Partials      297      297           
Flag Coverage Δ
unittests 67.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants