From 4607954d17b2c854935e915d0f70e54024093719 Mon Sep 17 00:00:00 2001 From: Dmitry Filimonov Date: Thu, 28 Oct 2021 14:53:02 -0700 Subject: [PATCH 1/2] disables watch mode, imporves error message --- scripts/webpack/webpack.dev.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/scripts/webpack/webpack.dev.js b/scripts/webpack/webpack.dev.js index f8a63fd250..e117d1ac16 100644 --- a/scripts/webpack/webpack.dev.js +++ b/scripts/webpack/webpack.dev.js @@ -11,7 +11,6 @@ const common = require('./webpack.common'); const sleep = (ms) => new Promise((res) => setTimeout(res, ms)); module.exports = merge(common, { - watch: true, devtool: 'eval-source-map', mode: 'development', entry: { @@ -27,7 +26,7 @@ module.exports = merge(common, { do { if (maxTries <= 0) { throw new Error( - 'Could not find pyroscope instance running on http://localhost:4040' + 'Could not find pyroscope instance running on http://localhost:4040. Make sure you have pyroscope server running on port :4040 (run `make build server`)' ); } res = request('GET', 'http://localhost:4040'); From 866e0e156b783634c591ace1f3a2e766762e4a6f Mon Sep 17 00:00:00 2001 From: Dmitry Filimonov Date: Thu, 28 Oct 2021 18:34:03 -0700 Subject: [PATCH 2/2] fix for snapshot tests --- .github/workflows/tests-js-snapshot.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests-js-snapshot.yml b/.github/workflows/tests-js-snapshot.yml index 781d247fed..70e6f7cf54 100644 --- a/.github/workflows/tests-js-snapshot.yml +++ b/.github/workflows/tests-js-snapshot.yml @@ -13,7 +13,7 @@ jobs: # if you ever update this container # remember to update the container that runs locally # (ie ./scripts/jest-snapshots) - container: node:current-slim + container: node:14.15-slim steps: - name: Checkout uses: actions/checkout@v2