Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check for service account user on public API resolution note #5286

Merged
merged 1 commit into from
Nov 21, 2024
Merged

fix: check for service account user on public API resolution note #5286

merged 1 commit into from
Nov 21, 2024

Conversation

matiasb
Copy link
Contributor

@matiasb matiasb commented Nov 21, 2024

@matiasb matiasb added pr:no public docs Added to a PR that does not require public documentation updates release:ignore PR will not be added to release notes labels Nov 21, 2024
@matiasb matiasb marked this pull request as ready for review November 21, 2024 11:40
@matiasb matiasb requested a review from a team as a code owner November 21, 2024 11:40
vadimkerr
vadimkerr approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@vadimkerr vadimkerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matiasb matiasb added this pull request to the merge queue Nov 21, 2024
Merged via the queue into dev with commit 77364b4 Nov 21, 2024
30 checks passed
@matiasb matiasb deleted the matiasb/fix-service-account-user-resolution-note branch November 21, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadimkerr vadimkerr vadimkerr approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates release:ignore PR will not be added to release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matiasb @vadimkerr