Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move YAML out of website sources #982

Merged
merged 1 commit into from
Feb 1, 2022
Merged

Move YAML out of website sources #982

merged 1 commit into from
Feb 1, 2022

Conversation

jdbaldry
Copy link
Member

What this PR does:

The website cannot handle YAML files being in amongst the markdown
files used in the Hugo build.

Signed-off-by: Jack Baldry [email protected]

Which issue(s) this PR fixes:

Fixes #882

Checklist

  • Tests updated

Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're using embedmd to embed .yaml files into the documentation .md. Look for "embeddb" in docs/ and Makefile. You need to update paths there.

@jdbaldry
Copy link
Member Author

jdbaldry commented Feb 1, 2022

We're using embedmd to embed .yaml files into the documentation .md. Look for "embeddb" in docs/ and Makefile. You need to update paths there.

I believe I had already captured the embedded YAML sources by updating the paths in the embedmd directive?

I took another look just in case and realized I had missed the prometheus-frontend.yml file though.

I have rebased to fix up the conflicts and also include prometheus-frontend.yml in the moved files.

The website cannot handle YAML files being in amongst the markdown
files used in the Hugo build.

Signed-off-by: Jack Baldry <[email protected]>
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pracucci pracucci enabled auto-merge (squash) February 1, 2022 15:16
@pracucci pracucci merged commit 744b75d into main Feb 1, 2022
@pracucci pracucci deleted the jdb/2022-01-move-yaml branch February 1, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate sync'ing YAML configuration files to the Grafana Website
3 participants