Push images to docker hub #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @aknuds1 who was helping me out with sorting out the Docker hub permissions/credentials |
pracucci
reviewed
Jan 28, 2022
Yes makes sense. I also need to figure out the multi-arch situation, but I think the images are all amd64 the way it is right now. |
pracucci
approved these changes
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that mimirtool and mimir are pushed to Dockerhub grafana/mimirtool and grafana/mimir. The other images are still using the
us.gcr.io/kubernetes-devregistryI have actually pushed to the image repos using this test PR:
What is left to be done in follow up PRs:
Determine if the current image push is a new tag to the latest version. This will have to make sure that if you release a new patch version to an older version it will not overwrite latest,
Ensure the images pushed are actually multiarch (I don't think they are)