Tenant federation implementation of exemplar query interfaces #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56quarters
commented
Jan 27, 2022
56quarters
force-pushed
the
56quarters/tenant-federation-exemplars
branch
4 times, most recently
from
41d9956
to
b8e63ad
Compare
Allow queries with multiple tenants against exemplar endpoints. Queries for each tenant are split and run in parallel using the same logic as the existing tenant federation query endpoints. Similar to the existing federated endpoints, the label `__tenant_id__` is added to the set of series labels for each exemplar to indicate which tenant it was queried from. Signed-off-by: Nick Pillitteri <[email protected]>
56quarters
force-pushed
the
56quarters/tenant-federation-exemplars
branch
from
b8e63ad
to
609eadb
Compare
replay
reviewed
Feb 1, 2022
replay
reviewed
Feb 1, 2022
replay
reviewed
Feb 1, 2022
* Move shared code to common file Signed-off-by: Nick Pillitteri <[email protected]>
replay
reviewed
Feb 2, 2022
replay
approved these changes
Feb 2, 2022
Better test case names Signed-off-by: Nick Pillitteri <[email protected]>
simonswine
approved these changes
Feb 2, 2022
Signed-off-by: Nick Pillitteri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nick Pillitteri [email protected]
What this PR does:
Allow queries with multiple tenants against exemplar endpoints. Queries
for each tenant are split and run in parallel using the same logic as the
existing tenant federation query endpoints.
Similar to the existing federated endpoints, the label
__tenant_id__isadded to the set of series labels for each exemplar to indicate which tenant
it was queried from.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]