Write dashboard: allow using cortex_request_duration_seconds native histogram #8757
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,12 +33,14 @@ local utils = import 'mixin-utils/utils.libsonnet'; | |
| local variables = { | ||
| gatewayMatcher: $.jobMatcher($._config.job_names.gateway), | ||
| distributorMatcher: $.jobMatcher($._config.job_names.distributor), | ||
| ingesterMatcher: $.jobMatcher($._config.job_names.ingester), | ||
| queryFrontendMatcher: $.jobMatcher($._config.job_names.query_frontend), | ||
| rulerMatcher: $.jobMatcher($._config.job_names.ruler), | ||
| alertmanagerMatcher: $.jobMatcher($._config.job_names.alertmanager), | ||
| namespaceMatcher: $.namespaceMatcher(), | ||
| writeHTTPRoutesRegex: $.queries.write_http_routes_regex, | ||
| writeGRPCDistributorRoutesRegex: $.queries.write_grpc_distributor_routes_regex, | ||
| writeGRPCIngesterRoute: $.queries.write_grpc_ingester_route, | ||
| readHTTPRoutesRegex: $.queries.read_http_routes_regex, | ||
| perClusterLabel: $._config.per_cluster_label, | ||
| recordingRulePrefix: $.recordingRulePrefix($.jobSelector('any')), // The job name does not matter here. | ||
|
|
@@ -47,13 +49,12 @@ local utils = import 'mixin-utils/utils.libsonnet'; | |
| }, | ||
|
|
||
| write_http_routes_regex: 'api_(v1|prom)_push|otlp_v1_metrics', | ||
| write_grpc_distributor_routes_regex: '/distributor.Distributor/Push|/httpgrpc.*', | ||
| write_grpc_ingester_route: '/cortex.Ingester/Push', | ||
| read_http_routes_regex: '(prometheus|api_prom)_api_v1_.+', | ||
| query_http_routes_regex: '(prometheus|api_prom)_api_v1_query(_range)?', | ||
|
|
||
| gateway: { | ||
| readRequestsPerSecond: 'cortex_request_duration_seconds_count{%(gatewayMatcher)s, route=~"%(readHTTPRoutesRegex)s"}' % variables, | ||
|
|
||
| local p = self, | ||
|
|
@@ -69,12 +70,9 @@ local utils = import 'mixin-utils/utils.libsonnet'; | |
| }, | ||
|
|
||
| distributor: { | ||
| local p = self, | ||
| requestsPerSecondMetric: 'cortex_request_duration_seconds', | ||
| writeRequestsPerSecondSelector: '%(distributorMatcher)s, route=~"%(writeGRPCDistributorRoutesRegex)s|%(writeHTTPRoutesRegex)s"' % variables, | ||
| samplesPerSecond: 'sum(%(groupPrefixJobs)s:cortex_distributor_received_samples:rate5m{%(distributorMatcher)s})' % variables, | ||
| exemplarsPerSecond: 'sum(%(groupPrefixJobs)s:cortex_distributor_received_exemplars:rate5m{%(distributorMatcher)s})' % variables, | ||
|
|
||
|
|
@@ -237,6 +235,9 @@ local utils = import 'mixin-utils/utils.libsonnet'; | |
| }, | ||
|
|
||
| ingester: { | ||
| requestsPerSecondMetric: 'cortex_request_duration_seconds', | ||
| writeRequestsPerSecondSelector: '%(ingesterMatcher)s, route="%(writeGRPCIngesterRoute)s"' % variables, | ||
|
|
||
| ingestOrClassicDeduplicatedQuery(perIngesterQuery, groupByLabels=''):: ||| | ||
| ( # Classic storage | ||
| sum by (%(groupByCluster)s, %(groupByLabels)s) (%(perIngesterQuery)s) | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,7 @@ local filename = 'mimir-writes.json'; | |
| assert std.md5(filename) == '8280707b8f16e7b87b840fc1cc92d4c5' : 'UID of the dashboard has changed, please update references to dashboard.'; | ||
| ($.dashboard('Writes') + { uid: std.md5(filename) }) | ||
| .addClusterSelectorTemplates() | ||
| .addShowNativeLatencyVariable() | ||
| .addRowIf( | ||
| $._config.show_dashboard_descriptions.writes, | ||
| ($.row('Writes dashboard description') { height: '125px', showTitle: false }) | ||
|
|
@@ -97,25 +98,23 @@ local filename = 'mimir-writes.json'; | |
| .addPanelIf( | ||
| $._config.gateway_enabled, | ||
| $.panel('Requests / sec') + | ||
| $.statPanel(utils.ncHistogramSumBy(utils.ncHistogramCountRate($.queries.gateway.requestsPerSecondMetric, $.queries.gateway.writeRequestsPerSecondSelector)), format='reqps') | ||
| ) | ||
| ) | ||
| .addRowIf( | ||
| $._config.gateway_enabled, | ||
| $.row('Gateway') | ||
| .addPanel( | ||
| $.timeseriesPanel('Requests / sec') + | ||
| $.qpsPanelNativeHistogram($.queries.gateway.requestsPerSecondMetric, $.queries.gateway.writeRequestsPerSecondSelector) | ||
| ) | ||
| .addPanel( | ||
| $.timeseriesPanel('Latency') + | ||
| $.latencyRecordingRulePanelNativeHistogram($.queries.gateway.requestsPerSecondMetric, $.jobSelector($._config.job_names.gateway) + [utils.selector.re('route', $.queries.write_http_routes_regex)]) | ||
| ) | ||
| .addPanel( | ||
| $.timeseriesPanel('Per %s p99 latency' % $._config.per_instance_label) + | ||
| $.perInstanceLatencyPanelNativeHistogram('0.99', $.queries.gateway.requestsPerSecondMetric, $.jobSelector($._config.job_names.gateway) + [utils.selector.re('route', $.queries.write_http_routes_regex)]) | ||
| ) | ||
| ) | ||
| .addRow( | ||
|
|
@@ -131,7 +130,7 @@ local filename = 'mimir-writes.json'; | |
| When distributor is not configured to use "early" request rejection, then rejected requests are also counted as "errors". | ||
| ||| | ||
| ) + | ||
| $.qpsPanelNativeHistogram($.queries.distributor.requestsPerSecondMetric, $.queries.distributor.writeRequestsPerSecondSelector) + | ||
| if $._config.show_rejected_requests_on_writes_dashboard then | ||
| { | ||
| targets: [ | ||
|
|
@@ -151,13 +150,11 @@ local filename = 'mimir-writes.json'; | |
| ) | ||
| .addPanel( | ||
| $.timeseriesPanel('Latency') + | ||
| $.latencyRecordingRulePanelNativeHistogram($.queries.distributor.requestsPerSecondMetric, $.jobSelector($._config.job_names.distributor) + [utils.selector.re('route', '/distributor.Distributor/Push|/httpgrpc.*|%s' % $.queries.write_http_routes_regex)]) | ||
| ) | ||
| .addPanel( | ||
| $.timeseriesPanel('Per %s p99 latency' % $._config.per_instance_label) + | ||
| $.perInstanceLatencyPanelNativeHistogram('0.99', $.queries.distributor.requestsPerSecondMetric, $.jobSelector($._config.job_names.distributor) + [utils.selector.re('route', '/distributor.Distributor/Push|/httpgrpc.*|%s' % $.queries.write_http_routes_regex)]) | ||
| ) | ||
| .addPanelIf( | ||
| $._config.show_ingest_storage_panels, | ||
|
|
@@ -203,7 +200,7 @@ local filename = 'mimir-writes.json'; | |
| When ingester is not configured to use "early" request rejection, then rejected requests are also counted as "errors". | ||
| ||| | ||
| ) + | ||
| $.qpsPanelNativeHistogram($.queries.ingester.requestsPerSecondMetric, $.queries.ingester.writeRequestsPerSecondSelector) + | ||
| if $._config.show_rejected_requests_on_writes_dashboard then | ||
| { | ||
| targets: [ | ||
|
|
@@ -223,13 +220,11 @@ local filename = 'mimir-writes.json'; | |
| ) | ||
| .addPanel( | ||
| $.timeseriesPanel('Latency') + | ||
| $.latencyRecordingRulePanelNativeHistogram($.queries.ingester.requestsPerSecondMetric, $.jobSelector($._config.job_names.ingester) + [utils.selector.eq('route', '/cortex.Ingester/Push')]) | ||
| ) | ||
| .addPanel( | ||
| $.timeseriesPanel('Per %s p99 latency' % $._config.per_instance_label) + | ||
| $.perInstanceLatencyPanelNativeHistogram('0.99', $.queries.ingester.requestsPerSecondMetric, $.jobSelector($._config.job_names.ingester) + [utils.selector.eq('route', '/cortex.Ingester/Push')]) | ||
| ) | ||
| ) | ||
| .addRowIf( | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,8 +8,8 @@ | |
| "subdir": "grafana-builder" | ||
| } | ||
| }, | ||
| "version": "ea6f2601969aa12c02dbca761ce4316aff036af2", | ||
| "sum": "udZaafkbKYMGodLqsFhEe+Oy/St2p0edrK7hiMPEey0=" | ||
| }, | ||
| { | ||
| "source": { | ||
|
|
@@ -18,8 +18,8 @@ | |
| "subdir": "mixin-utils" | ||
| } | ||
| }, | ||
| "version": "ea6f2601969aa12c02dbca761ce4316aff036af2", | ||
| "sum": "mzLmCv9n3ldLChVGPfyRJOVKoBw+dfK40vU9792aHIM=" | ||
| } | ||
| ], | ||
| "legacyImports": false | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: