Change default server.http-listen-port to 8080
#871
Conversation
dimitarvdimitrov
changed the title
server.http-listen-port to 8080server.http-listen-port to 8080
|
This is now ready for review. |
|
cc @jdbaldry @osg-grafana since this will be a significant breaking change for the migration guide |
|
We should change the |
dimitarvdimitrov
force-pushed
the
dimitar/http_listen_port_default_8080
branch
from
d9c552a
to
778506f
Compare
operations/mimir/common.libsonnet
Outdated
| containerPort.newNamed(name='http-metrics', containerPort=80), | ||
| containerPort.newNamed(name='http-metrics', containerPort=8080), |
There was a problem hiding this comment.
I'm unsure what will happen with these changes after merge. Will they get immediately pulled into deployment tools and applied? If so, that will break all current deployments. Can someone confirm this won't happen?
There was a problem hiding this comment.
It won't happen without someone's approval. However we still need to support port 80 until we switch all our deployed images to use port 8080 (and not just Mimir's image but GEM's image too). It may be best to have a config option for this.
There was a problem hiding this comment.
after the weekly call we found out that what the image exposes isn't tied to what the container can listen on. So this shouldn't be a concern anymore, correct @pstibrany?
To my understanding we should still create a jsonnet "revert" PR to set the server port to 80. So once this PR (871) is merged and deployed, the change in the default port wouldn't affect the running services. I'll get started on that PR.
There was a problem hiding this comment.
I don't see -server.http-listen-port being overridden in our jsonnet, so restarted components will actually start using new default port 8080. I think we want to update all (!) component definitions in jsonnet to keep using port 80 via this command line flag. This should also be reflected in named ports definitions. (I'd suggest to make port 80 configurable via field in _config).
There was a problem hiding this comment.
added a similar config in 117b90c
|
thanks for spotting this @pstibrany, I found a few other mentions of port I'm unsure about some of the changes though. Left a comment in operations/mimir/common.libsonnet |
dimitarvdimitrov
force-pushed
the
dimitar/http_listen_port_default_8080
branch
from
37691cb
to
117b90c
Compare
There was a problem hiding this comment.
Changes LGTM. Thanks for addressing my feedback! Before merging I would be glad if @pstibrany could take another look, since he already commented on the PR.
dimitarvdimitrov
force-pushed
the
dimitar/http_listen_port_default_8080
branch
from
cee276d
to
8a96513
Compare
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov <[email protected]>
dimitarvdimitrov
force-pushed
the
dimitar/http_listen_port_default_8080
branch
from
8a96513
to
fa71733
Compare
This complements the change by #871 in backward_compatibility.go Signed-off-by: Dimitar Dimitrov <[email protected]>
This complements the change by #871 in backward_compatibility.go Signed-off-by: Dimitar Dimitrov <[email protected]>
Signed-off-by: Dimitar Dimitrov [email protected]
What this PR does:
Sets the default
-server.http-listen-portto 8080.Which issue(s) this PR fixes:
Fixes https://github.com/grafana/mimir-squad/issues/481
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]