Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate maintainers list #792

Merged
merged 24 commits into from
Jan 26, 2022
Merged

Populate maintainers list #792

merged 24 commits into from
Jan 26, 2022

Conversation

replay
Copy link
Contributor

@replay replay commented Jan 18, 2022

This PR is the result of the discussion in today's (2022-01-18) Mimir weekly meeting, it sets the initial list of Mimir maintainers to the following:

Existing Cortex maintainers employed at Grafana Labs + Grafana Labs employees in the Mimir team that have had tenure over 6 months + Tech Leads

@pstibrany pstibrany requested a review from RichiH January 18, 2022 17:11
@pstibrany
Copy link
Member

/cc @johannaratliff, @replay, @treid314, @56quarters, @aknuds1, @colega, @stevesg, @krajorama, @simonswine, @pstibrany, @pracucci, @gotjosh, @cyriltovena, @gouthamve, @bboreham

@colega
Copy link
Contributor

colega commented Jan 18, 2022

Thanks!

MAINTAINERS.md Outdated
@@ -1 +1,15 @@
There are currently no default maintainer or codebase-specific maintainers. Please see the list of maintainers in our [governance](GOVERNANCE.md).
* Arve Knudsen ([@aknuds1](https://github.com/aknuds1))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this like should be moved to GOVERNANCE.md (see the list of members there). It's how it works in Loki too.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also we should name the company for each member, like Loki do.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a MAINTAINERS.md in the Loki root directory, but Ed is the only person listed there (without name or company):
https://github.com/grafana/loki/blob/main/MAINTAINERS.md
However, in governance.md there is a list of Team members with company name: https://github.com/grafana/loki/blob/main/docs/sources/community/governance.md#team-members

Are you suggesting that instead of adding everybody as a maintainer I should add them as team members in GOVERNANCE.md? Or should I add the list of people in the section Maintainers of GOVERNANCE.md (and also copy the same list to team members)?
https://github.com/grafana/mimir/blob/main/GOVERNANCE.md#maintainers

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's involve @RichiH in this. I'm not sure about it. He knows better.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to have at least one technical writer in the maintainer group so that we can update documentation based on Docs Squad best practices?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, definitely. We can add you @osg-grafana.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@replay I got an answer from Richi + Ganesh on how we should do it:

Governance page has the members that are part of team mailing list and have the formal voting power in the project.
Maintainers list is an additional list which can repeat the names from the governance and can specify what each person listed is responsible for. We have non team members as well here and not all team members are here. Contributors will look at this list to know who is responsible for the part of software to notify them on issues/PRs and can expect a response or review.

TL;DR for now same list on both places. In MANTAINERS.md @osg-grafana should be be mentioned as maintainer for docs/.

Copy link
Member

@RichiH RichiH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend following the structure of https://github.com/prometheus/prometheus/blob/main/MAINTAINERS.md with a few default maintainers plus a few subdirectory specific ones. This would make it easier for external people to find out who to talk to about what specific areas.

If it's not possible to split out maintainership responsibilities, pointing to the governance is arguably less maintenance burden, but have it twice also works.

MAINTAINERS.md Outdated Show resolved Hide resolved
@replay
Copy link
Contributor Author

replay commented Jan 20, 2022

Thanks for all the feedback on this PR and here on Slack.

I have updated MAINTAINERS.md and GOVERNANCE.md. The number of maintainers for main is now down to 11, how does that sound @bboreham? Also, there are two maintainers for sub-directories; @osg-grafana for docs and @gotjosh for ruler and AM.

@stevesg
Copy link
Contributor

stevesg commented Jan 20, 2022

Over concern of too many maintainers I am happy to be removed.

Copy link
Contributor

@simonswine simonswine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth noting that from next quarter on, my focus will be on Loki. There is a good chance that someone else might be a better fit for a maintainer role.

@replay
Copy link
Contributor Author

replay commented Jan 20, 2022

Worth noting that from next quarter on, my focus will be on Loki. There is a good chance that someone else might be a better fit for a maintainer role

Thanks for letting me know @simonswine, I'll remove you from the list then if that's fine with you

Signed-off-by: Mauro Stettler <[email protected]>
Signed-off-by: Mauro Stettler <[email protected]>
Signed-off-by: Mauro Stettler <[email protected]>
Signed-off-by: Mauro Stettler <[email protected]>
Signed-off-by: Mauro Stettler <[email protected]>
Signed-off-by: Mauro Stettler <[email protected]>
Signed-off-by: Mauro Stettler <[email protected]>
Signed-off-by: Mauro Stettler <[email protected]>
Signed-off-by: Mauro Stettler <[email protected]>
Signed-off-by: Mauro Stettler <[email protected]>
Signed-off-by: Mauro Stettler <[email protected]>
Signed-off-by: Mauro Stettler <[email protected]>
Signed-off-by: Mauro Stettler <[email protected]>
GOVERNANCE.md Outdated Show resolved Hide resolved
Signed-off-by: Mauro Stettler <[email protected]>
@replay
Copy link
Contributor Author

replay commented Jan 24, 2022

Since the discussions appear to have settled, I will go ahead and merge this.

Edit: I'm not authorized to merge this. Could somebody who is authorized merge please?

@grafana-dee
Copy link

Discussion not settled 😁 Steve and Krajo are both absent from the PR despite the conversation having previously agreed that they are maintainers. If we add them back into the PR I would accept too.

Signed-off-by: Richard Hartmann <[email protected]>
Copy link
Collaborator

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@replay replay merged commit af3a3b5 into main Jan 26, 2022
@replay replay deleted the populate_maintainers_list branch January 26, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.