Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise "About tenant IDs" #1158

Merged
merged 3 commits into from
Feb 12, 2022
Merged

Revise "About tenant IDs" #1158

merged 3 commits into from
Feb 12, 2022

Conversation

jdbaldry
Copy link
Member

Relates to #1109

Signed-off-by: Jack Baldry [email protected]

Signed-off-by: Jack Baldry <[email protected]>
@jdbaldry jdbaldry added the type/docs Improvements or additions to documentation label Feb 10, 2022
## Supported characters

The following character sets are generally **safe for use in the tenant ID**:
Tenant IDs must be less than 150 bytes/characters in length and must comprise only supported characters:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be pedantic: they must be less than or equal to 150 bytes/characters in length:

if len(s) > 150 {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in e239d1d

Copy link
Contributor

@replay replay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with one comment

@jdbaldry jdbaldry merged commit e8751a2 into main Feb 12, 2022
@jdbaldry jdbaldry deleted the jdb/2022-02-about-tenant-ids branch February 12, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants